Modifying the Haste/Slow Status Effect script

Update: I tried to carry out what you suggested in your second method. I created a new script, HasteStatusController, and changed the HasteStatusEffect script such that it now sends out the notification for the HasteStatusController to increase the SPD stat when it is enabled, and the reverse when it is disabled. Here's the code for my two scripts:



HasteStatusController

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class HasteStatusController : MonoBehaviour {

void Awake()
{
Stats stats = GetComponent<Stats>();
}

void OnEnable()
{
this.AddObserver(HasteActivate, HasteStatusEffect.HasteBeginNotification, gameObject.GetComponentInChildren<HasteStatusEffect>());
this.AddObserver(HasteRemove, HasteStatusEffect.HasteEndedNotification, gameObject.GetComponentInChildren<HasteStatusEffect>());
}

void OnDisable()
{
this.RemoveObserver(HasteActivate, HasteStatusEffect.HasteBeginNotification, gameObject.GetComponentInChildren<HasteStatusEffect>());
this.RemoveObserver(HasteRemove, HasteStatusEffect.HasteEndedNotification, gameObject.GetComponentInChildren<HasteStatusEffect>());
}

void HasteActivate(object sender, object args)
{
Stats stats = this.GetComponent<Stats>();
stats.SetValue(StatTypes.SPD, stats[StatTypes.SPD] * 2, false);
}

void HasteRemove(object sender, object args)
{
Stats stats = this.GetComponent<Stats>();
stats.SetValue(StatTypes.SPD, stats[StatTypes.SPD] / 2, false);
}
}






HasteStatusEffect

using UnityEngine;
using System.Collections;

public class HasteStatusEffect : StatusEffect
{
public const string HasteBeginNotification = "HasteStarted";
public const string HasteEndedNotification = "HasteEnded";

void OnEnable()
{
this.PostNotification(HasteBeginNotification);
}

void OnDisable()
{
this.PostNotification(HasteEndedNotification);
}
}

However, the result is STILL the same. Even after I had specified that I only wanted the HasteStatusController script to only listen to notifications from the HasteStatusEffect script that is attached to the same game object that it is also attached to, it is still listening to notifications from the HasteStatusEffect scripts that are attached to other game objects on the field. This is concluded after observing how the units' SPD that were affected by Haste were multiplied by whatever number of units that were affected by it (i.e. if there were 2 units affected, each of the 2 unit's SPD stat would be multiplied by 4 times and so on).

To answer your questions:
1. The haste status effect was removed from the unit, but the "Status" component (the sender of the notification) is still attached to the unit, so you can grab a reference to any other components on the unit as well.
2. The observer method of the notification is passed the "sender" as a parameter. You don't have to do anything special to look it up, but you do need to be able to know what it is, and cast it to the right kind of object.

Now, take a look at the code snippet I posted above. It might help to clear up a few things. I created a "controller" script and attached it to the "Battle Controller" game object - note it is not attached to any unit. When the scene loads, I manually assign a unit to the public target field that I exposed (this is just for testing purposes after all). Then I press the 'a' key to add a haste status effect - I can then inspect the units hierarchy if I want. Then I press the 'r' key to remove the status effect when I am ready.

I use the OnEnable and OnDisable to register and unregister from status notifications, but I do not specify a sender to observe, so that it listens to any status notification from any unit. That is how you would structure the real controller or system style pattern I had mentioned. In the observer methods, OnAdd and OnRemove, I first check the type of args to determine whether or not the notification refers to a type of HasteStatusEffect or not. If it doesn't, I abort early using the return statement. If it does, then I cast the sender of the notification (the status component) to a new variable of that type so that I can work with it and its GameObject hierarchy accordingly. In other words, you could grab a reference to the "Stats" component to raise or lower the speed stat at this point.

I think you understand it all correctly, but to be sure I will add that if three units were given haste, that the controller would receive a separate notification for each of the three units. This means that the OnAdd method would be called three times, the first time from a status component attached to unit 'A', next by the status component attached to unit 'B' etc. The code in OnAdd will be the same and work regardless of which unit is being handled.

You could test this in the sample code snippet I gave you by assigning different units (with different names) to the target and running the test. The Debug Log will print the name of the unit that is targeted.