Buff and debuff System

think what i am going to do is this:
- make it similiar to the performdamageaction instead it will be a onperformbuffaction
i might have a debuff one as well or i may just use a negative instead on cards in the info section we shall see there - might look better if i add separate debuff action

anywho so itll be pretty much the same as the below but the object will be different (IE combatant for attack - health armor (if applicable) to Iarmored that kind of thing

no sure what to do with the filter attack targets

your prototype is a bit different then your tutorial version

- anyways hope this works and if anyone has any suggestions - im all ears!

void OnPerformDamageAction(object sender, object args)
{
var action = args as DamageAction;
foreach (IDestructable target in action.targets)
{
target.hitPoints -= action.amount;
if (target.hitPoints < 0)
target.hitPoints = 0;
}
}

void OnFilterAttackTargets(object sender, object args)
{
var candidates = args as List<Card>;
for (int i = candidates.Count - 1; i >= 0; --i)
{
var destructable = candidates as IDestructable;
if (destructable == null)
candidates.RemoveAt(i);
}
}

ya im not quite sure how to do that -
would i instantiate a separate object for each buff so that it can be interacted with by the player ? meaning i would need to display the buff on the screen as well - unless i chose a system in which the buff debuffs taken off were auto targetted either manual or FIFO/LIFO or something?
that adds another complexity to the targetting system cause now the spell can target buffs and debuffs

k so buff : CArd

public int duration;
public int amount;
public string stat;

which ienchantable has
list <Buff> Buffs;

which Hero inherits Ienchantable

so far i have that and now i have to figure out how to implement the boosting process with the system you designed.

I am missing how to make sure the action system is taken into consideration - this is a doozy of an issue - damage action wont work because its more of a one off case - and the ability is close but doesnt have a duration one as well - i can probably add one but that still doesnt really help because i still need a hwhole new system for targeting and removing the buff - so i have to figure out how to make sure i do this correctly through that appropriate gameaction container system you made.

Just came back from a nice vacation. Sounds like you are learning a lot and are making progress, so that's good. I can confirm that the approach you should take is to create a new system for this - all features should exist in their own system. This is an architectural practice where everything should have a single responsibility. I might approach this challenge by making an aspect of a card rather than making a subclass of a card. You can still check things like whether the card conforms to a type of interface to know if a certain type of buff is relevant or not. Their should be a new action to apply the aspect to a card, and the buff system would observe the action to "apply" it. In Hearthstone, buffs and debuffs are applied and are displayed as parts of the card. You dont target individual buffs to modify, so if you were to say, '"silence" the card, then all buffs would be removed.

Good luck!